Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Reinstate 5 ids #3143

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Aug 8, 2023

In PR #3063, I inadvertently un-defined 5 ids:

  • thisbooleanvalue
  • thissymbolvalue
  • thisnumbervalue
  • thisbigintvalue
  • thisstringvalue

This PR reinstates them as oldids.

@ljharb ljharb requested a review from a team August 9, 2023 02:37
@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Aug 16, 2023
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Aug 16, 2023
... that I inadvertently un-defined in PR tc39#3063.
@ljharb ljharb force-pushed the reinstate_thisfoovalue_ids branch from a6b4062 to c1cf8cc Compare August 16, 2023 22:31
... that I inadvertently un-defined in PR tc39#3063.
@ljharb ljharb force-pushed the reinstate_thisfoovalue_ids branch from c1cf8cc to 9a75782 Compare August 16, 2023 22:36
@ljharb ljharb merged commit 9a75782 into tc39:main Aug 16, 2023
@jmdyck jmdyck deleted the reinstate_thisfoovalue_ids branch August 17, 2023 15:52
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
... that I inadvertently un-defined in PR tc39#3063.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants