Editorial: Add assertion that generatorKind is not non-generator #3379
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
reviewed
Jul 30, 2024
syg
approved these changes
Jan 22, 2025
michaelficarra
approved these changes
Jan 22, 2025
bakkot
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
LGTM; we'll pull in the suggested change when landing.
(It's a little silly that we call GetGeneratorKind outside of generators, but we do for return statements. I'd mildly prefer to instead check if we are in a generator, and then do GetGeneratorKind, so that GetGeneratorKind can assert that it is always called from within a generator. But that is a different PR.)
bakkot
added
the
ready to merge
ljharb
force-pushed
the
assert-yield-generatorkind
branch
from
a04e9de to
ac5cd49
Compare
ljharb
pushed a commit
to d01c2/ecma262
that referenced
this pull request
Jan 23, 2025
ljharb
pushed a commit
to d01c2/ecma262
that referenced
this pull request
Jan 23, 2025
ljharb
force-pushed
the
assert-yield-generatorkind
branch
from
ac5cd49 to
6fe229b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ljharb
force-pushed
the
assert-yield-generatorkind
branch
from
6fe229b to
df1c3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to runtime semantics of
_YieldExpression_ : yield * _AssignmentExpression_evaluation,_generatorKind_is NON-GENERATOR, SYNC, or ASYNC. However, the type of second parameter ofGetIteratoris SYNC or ASYNC in current specification. This is type-mismatch. I thinkGetGeneratorKindcannot return NON-GENERATOR in this case, so this PR includes adding assertion thatgeneratorKindis not NON-GENERATOR.