New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Clamp size before using with "substring of" #3400

Merged

ljharb merged 1 commit into tc39:main from gibson042:gh-3261-clamp-substring-length

Aug 26, 2024

Contributor

gibson042 commented Aug 23, 2024

Fixes #3261

michaelficarra approved these changes

View reviewed changes

Member

michaelficarra left a comment

LGTM. Editorial because substring behaviour is not defined for bounds beyond the ends of the string.

michaelficarra added editorial change spec bug labels

bakkot approved these changes

View reviewed changes

michaelficarra added the ready to merge label


          Editorial: Clamp size before using with "substring of" (tc39#3400)

815aa8a

Fixes tc39#3261

ljharb force-pushed the gh-3261-clamp-substring-length branch from 49b61b2 to 815aa8a Compare

August 26, 2024 18:16

ljharb merged commit 815aa8a into tc39:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial change ready to merge spec bug