-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Update range comparisons involving a zero #3523
Editorial: Update range comparisons involving a zero #3523
Conversation
1. Let _taRecord_ be MakeTypedArrayWithBufferWitnessRecord(_O_, ~unordered~). | ||
1. NOTE: Bounds checking is not a synchronizing operation when _O_'s backing buffer is a growable SharedArrayBuffer. | ||
1. If IsTypedArrayOutOfBounds(_taRecord_) is *true*, return *false*. | ||
1. Let _length_ be TypedArrayLength(_taRecord_). | ||
1. If ℝ(_index_) < 0 or ℝ(_index_) ≥ _length_, return *false*. | ||
1. If ℝ(_index_) ≥ _length_, return *false*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure this is indeed editorial, but I'd like @syg to confirm. (Specifically, this change means that passing -1
will now skip the MakeTypedArrayWithBufferWitnessRecord
step, but per the note about bounds checking not being a synchronizing operation I think that's not observable.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think because it's unordered it is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending approval from Shu for the TA change. The esmeta failures can be fixed by removing TypedArrayGetElement
and TypedArraySetElement
from esmeta-ignore.json, per the CI logs, which we can do when merging if you don't get there first.
060a90e
to
f2eff8d
Compare
< -0𝔽
or> +0𝔽
(there was one exception).