Normative: Clarify rules around NewTarget in eval #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I forgot to take this with #685. Fixing merge conflicts... |
bterlson
force-pushed
the
new.target-eval-fix
branch
2 times, most recently
from
2487a02 to
645fd53
Compare
Previously, NewTarget was disallowed in nested eval contexts and in eval inside arrow functions. This change allows NewTarget inside eval anywhere it would be allowed outside of eval.
bterlson
force-pushed
the
new.target-eval-fix
branch
from
645fd53 to
99fd453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, NewTarget was disallowed in nested eval contexts and in eval inside arrow functions. This change allows NewTarget inside eval anywhere it would be allowed outside of eval.
This PR is on top of #685 as it uses a similar pattern.