Make [[Delete]] on module namespace return false for @@toStringTag. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A module namespace exotic object has an own Symbol.toStringTag property, which is non-configurable. This patch changes [[Delete]] to return false rather than true for this property, thus making its behavior consistent with other own properties of the object.
|
This looks good to me. I'll tag it needs consensus just in case, since it's easy to discuss next week :) |
bterlson
added
the
needs consensus
|
We have consensus. |
bakkot
added
the
needs test262 tests
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Feb 16, 2017
https://bugs.webkit.org/show_bug.cgi?id=168280 Reviewed by Saam Barati. JSTests: * modules/namespace-object-symbol-iterator-name.js: * modules/namespace-object-typed-array-fast-path.js: * modules/namespace.js: (shouldBe.JSON.stringify.Reflect.getOwnPropertyDescriptor): (shouldThrow): Source/JavaScriptCore: Reflect updates to the module namespace object. 1. @@iterator property is dropped[1]. 2. @@toStringTag property becomes non-configurable[1]. 3. delete with Symbol should be delegated to the JSObject's one[2]. [1]: https://tc39.github.io/ecma262/#sec-module-namespace-objects [2]: tc39/ecma262#767 * runtime/JSModuleNamespaceObject.cpp: (JSC::JSModuleNamespaceObject::finishCreation): (JSC::JSModuleNamespaceObject::deleteProperty): (JSC::moduleNamespaceObjectSymbolIterator): Deleted. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@212430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
|
Still need tests but I'm going to merge this. |
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=168280 Reviewed by Saam Barati. JSTests: * modules/namespace-object-symbol-iterator-name.js: * modules/namespace-object-typed-array-fast-path.js: * modules/namespace.js: (shouldBe.JSON.stringify.Reflect.getOwnPropertyDescriptor): (shouldThrow): Source/JavaScriptCore: Reflect updates to the module namespace object. 1. @@iterator property is dropped[1]. 2. @@toStringTag property becomes non-configurable[1]. 3. delete with Symbol should be delegated to the JSObject's one[2]. [1]: https://tc39.github.io/ecma262/#sec-module-namespace-objects [2]: tc39/ecma262#767 * runtime/JSModuleNamespaceObject.cpp: (JSC::JSModuleNamespaceObject::finishCreation): (JSC::JSModuleNamespaceObject::deleteProperty): (JSC::moduleNamespaceObjectSymbolIterator): Deleted. Canonical link: https://commits.webkit.org/185447@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@212430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A module namespace exotic object has an own Symbol.toStringTag property, which
is non-configurable. This patch changes [[Delete]] to return false rather than
true for this property, thus making its behavior consistent with other own
properties of the object.
See also: #747