Normative: Allow Collator to get collation from option #459

FrankYFTang · 2020-06-16T20:36:31Z

Collator already have "co" in [[RelevantExtensionKeys]] internal slot and therefore the usage by using "-u-co-$collationkey" is already supported in ECMA402.

This PR will also make our extension / option handling in ECMA402 consistent.

I check other object and I believe this is the only inconsistent handling between u extension and option now.

Close #380

Collator already have "co" in [[RelevantExtensionKeys]] internal slot and therefore the usage by using "-u-co-$collationkey" is already supported in ECMA402. Close #380

spec/collator.html

To make it the same as the order already in Table 3: Resolved Options of Collator Instances

FrankYFTang

PTAL

sffc · 2020-06-17T10:15:44Z

Looks good! Let's try to get consensus at the next 402 meeting.

spec/collator.html

+        1. Let _collation_ be ? GetOption(_options_, `"collation"`, `"string"`, *undefined*, *undefined*).
+        1. If _collation_ is not *undefined*, then
+          1. If _collation_ does not match the Unicode Locale Identifier `type` nonterminal, throw a *RangeError* exception.
+        1. Set _opt_.[[co]] to _collation_.


anba · 2020-06-19T08:26:56Z

spec/collator.html

@@ -14,6 +14,10 @@ <h1>InitializeCollator ( _collator_, _locales_, _options_ )</h1>
        The abstract operation InitializeCollator accepts the arguments _collator_ (which must be an object), _locales_, and _options_. It initializes _collator_ as a *Collator* object. The following steps are taken:
      </p>

+      <p>
+        The following algorithm refers to the `type` nonterminal from <a href="http://www.unicode.org/reports/tr35/#Unicode_locale_identifier">UTS 35's Unicode Locale Identifier grammar</a>.


Nit: "https" instead of "http".

sffc · 2020-07-20T17:55:47Z

TC39 gave consensus for this change on 2020-07-20.

FrankYFTang · 2020-07-20T21:53:06Z

Just FYI
v8 implementation in https://chromium-review.googlesource.com/c/v8/v8/+/2309149
v8 bug https://bugs.chromium.org/p/v8/issues/detail?id=10732

FrankYFTang · 2020-07-21T18:23:25Z

I still have "You’re not authorized to merge this pull request." next to the grey "Merge pull request" button.

FrankYFTang · 2020-07-21T18:58:24Z

FYI- landed into v8 and should be available in Chrome 86

Per change in tc39/ecma402#459 Bug: v8:10732 Change-Id: I2ef21e8b450cbf9c61f987c61f3ba7d6959db81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309149 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#68976}

sffc · 2020-08-13T04:59:12Z

This PR has TG1 and TG2 consensus:

Constellation · 2020-09-15T22:03:56Z

FYI, JSC enabled it on Trunk https://trac.webkit.org/changeset/267102/webkit

FrankYFTang · 2020-09-21T18:39:28Z

FYI, JSC enabled it on Trunk https://trac.webkit.org/changeset/267102/webkit

thanks. I updated https://github.com/tc39/ecma402/wiki/Proposal-and-PR-Progress-Tracking

… r=yulia Implements the changes from the "has consensus" PR <tc39/ecma402#459>. Drive-by change: - Enable a named groups RegExp test which wasn't enabled when bug 1362154 was implemented. Differential Revision: https://phabricator.services.mozilla.com/D95734

https://bugs.webkit.org/show_bug.cgi?id=216529 Reviewed by Ross Kirsling. JSTests: * stress/intl-collator-co-extension.js: (shouldThrow): Source/JavaScriptCore: This patch adds "collation" option to Intl.Collator. We are already getting consensus[1], and will be integrated into the spec. Previously, passing "collation" is only available through "-u-co-" unicode extension in the passed locale. The proposal exposes collation option as an option to Intl.Collator so that we can set it easily. "collation" is used only when "usage" is "sort". "search" usage will filter out collation options since "search" itself is one of the "collation" option. [1]: tc39/ecma402#459 * runtime/IntlCollator.cpp: (JSC::IntlCollator::sortLocaleData): (JSC::IntlCollator::initializeCollator): Canonical link: https://commits.webkit.org/229383@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ryzokuken · 2021-05-17T11:02:22Z

@FrankYFTang @sffc https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator/Collator#parameters already lists "collation" as an accepted option for Intl.Collator. Does this PR need any further MDN documentation?

FrankYFTang · 2021-05-17T18:05:12Z

It seems they list the possible values there. Not sure what is missing. Please at least add "zhuyin" as possible value

<keyword>
    <key name="co" description="Collation type key" alias="collation">
        <type name="big5han" description="Pinyin ordering for Latin, big5 charset ordering for CJK characters (used in Chinese)"/>
        <type name="compat" description="A previous version of the ordering, for compatibility" since="26"/>
        <type name="dict" description="Dictionary style ordering (such as in Sinhala)" alias="dictionary"/>
        <type name="direct" description="Binary code point order (used in Hindi)" deprecated="true"/>
        <type name="ducet" description="The default Unicode collation element table order" since="2.0.1"/>
        <type name="emoji" description="Recommended ordering for emoji characters" since="27"/>
        <type name="eor" description="European ordering rules" since="24"/>
        <type name="gb2312" description="Pinyin ordering for Latin, gb2312han charset ordering for CJK characters (used in Chinese)" alias="gb2312han"/>
        <type name="phonebk" description="Phonebook style ordering (such as in German)" alias="phonebook"/>
        <type name="phonetic" description="Phonetic ordering (sorting based on pronunciation)"/>
        <type name="pinyin" description="Pinyin ordering for Latin and for CJK characters (used in Chinese)"/>
        <type name="reformed" description="Reformed ordering (such as in Swedish)"/>
        <type name="search" description="Special collation type for string search" since="1.9"/>
        <type name="searchjl" description="Special collation type for Korean initial consonant search" since="2.0.1"/>
        <type name="standard" description="Default ordering for each language"/>
        <type name="stroke" description="Pinyin ordering for Latin, stroke order for CJK characters (used in Chinese)"/>
        <type name="trad" description="Traditional style ordering (such as in Spanish)" alias="traditional"/>
        <type name="unihan" description="Pinyin ordering for Latin, Unihan radical-stroke ordering for CJK characters (used in Chinese)"/>
        <type name="zhuyin" description="Pinyin ordering for Latin, zhuyin order for Bopomofo and CJK characters (used in Chinese)" since="22"/>
    </key>

I think we should add all those missed from above (for example "zhuyin") except "search" and "standard" that is clearly stated not allowed in ECMA402

Allow Collator to get collation from option

e78413e

Collator already have "co" in [[RelevantExtensionKeys]] internal slot and therefore the usage by using "-u-co-$collationkey" is already supported in ECMA402. Close #380

FrankYFTang requested review from littledan, zbraniecki, sffc, gibson042 and anba June 16, 2020 20:36

sffc reviewed Jun 16, 2020

View reviewed changes

spec/collator.html Outdated Show resolved Hide resolved

spec/collator.html Outdated Show resolved Hide resolved

FrankYFTang added 2 commits June 16, 2020 14:05

Move the reading of the collation option earlier

2e2592a

To make it the same as the order already in Table 3: Resolved Options of Collator Instances

add reference of type to UTS 35

2cb96f3

FrankYFTang commented Jun 17, 2020

View reviewed changes

ryzokuken approved these changes Jun 17, 2020

View reviewed changes

leobalter changed the title ~~Allow Collator to get collation from option~~ Normative: Allow Collator to get collation from option Jun 18, 2020

leobalter added needs tests Small Smaller change solvable in a Pull Request labels Jun 18, 2020

leobalter requested changes Jun 18, 2020

View reviewed changes

zbraniecki approved these changes Jun 18, 2020

View reviewed changes

change ` to *

494f5a5

anba approved these changes Jun 19, 2020

View reviewed changes

change http to https

c38c436

FrankYFTang mentioned this pull request Jun 20, 2020

Change url to https #464

Merged

leobalter approved these changes Jun 23, 2020

View reviewed changes

gibson042 approved these changes Jul 21, 2020

View reviewed changes

sffc added has consensus Has consensus from TC39-TG2 has consensus (TG1) Has consensus from TC39-TG1 labels Aug 13, 2020

FrankYFTang mentioned this pull request Oct 6, 2020

Add the check of collation in options tc39/test262#2849

Merged

rwaldron added has tests and removed needs tests labels Oct 6, 2020

hamishwillee mentioned this pull request Dec 31, 2020

Add Intl.Collator option for collation mdn/browser-compat-data#8471

Merged

leobalter approved these changes Jan 5, 2021

View reviewed changes

leobalter merged commit a57ae15 into master Jan 5, 2021

leobalter deleted the FrankYFTang-patch-4 branch January 5, 2021 01:51

romulocintra mentioned this pull request Sep 29, 2021

add collator options mdn/content#9332

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normative: Allow Collator to get collation from option #459

Normative: Allow Collator to get collation from option #459

FrankYFTang commented Jun 16, 2020

FrankYFTang left a comment

sffc commented Jun 17, 2020

This comment was marked as resolved.

anba Jun 19, 2020

sffc commented Jul 20, 2020

FrankYFTang commented Jul 20, 2020

FrankYFTang commented Jul 21, 2020

FrankYFTang commented Jul 21, 2020

sffc commented Aug 13, 2020

Constellation commented Sep 15, 2020

FrankYFTang commented Sep 21, 2020

ryzokuken commented May 17, 2021

FrankYFTang commented May 17, 2021

Normative: Allow Collator to get collation from option #459

Normative: Allow Collator to get collation from option #459

Conversation

FrankYFTang commented Jun 16, 2020

FrankYFTang left a comment

Choose a reason for hiding this comment

sffc commented Jun 17, 2020

This comment was marked as resolved.

anba Jun 19, 2020

Choose a reason for hiding this comment

sffc commented Jul 20, 2020

FrankYFTang commented Jul 20, 2020

FrankYFTang commented Jul 21, 2020

FrankYFTang commented Jul 21, 2020

sffc commented Aug 13, 2020

Constellation commented Sep 15, 2020

FrankYFTang commented Sep 21, 2020

ryzokuken commented May 17, 2021

FrankYFTang commented May 17, 2021