Normative: Define @@toStringTag for Intl namespace object #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
requested review from
zbraniecki,
littledan,
anba,
gibson042 and
sffc
|
v8 tracking bug https://bugs.chromium.org/p/v8/issues/detail?id=10744 |
|
required v8 code change in https://chromium-review.googlesource.com/c/v8/v8/+/2315455 |
pull bot
pushed a commit
to ashu8912/v8
that referenced
this pull request
Aug 1, 2020
Implement tc39/ecma402#487 Also improve test/intl/toStringTag.js see also: tc39/test262#2712 Bug: v8:10744 Change-Id: I678876aa21f169a8dfcec8e3ce974978a8847fe0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315455 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/master@{#69185}
leobalter
approved these changes
Aug 13, 2020
|
TG2 achieved consensus today and this had consensus from TC39 as recorded here: tc39/ecma262#2057 (comment) |
caiolima
pushed a commit
to caiolima/webkit
that referenced
this pull request
Aug 25, 2020
https://bugs.webkit.org/show_bug.cgi?id=215715 Reviewed by Ross Kirsling. JSTests: * stress/intl-object.js: * test262/expectations.yaml: Mark 4 test cases as passing. Source/JavaScriptCore: This patch utilizes JSC_TO_STRING_TAG_WITHOUT_TRANSITION() to define Symbol.toStringTag on Intl namespace object, implementing the recent spec change [1] and aligning JSC with V8. Also, adds inherits() ASSERT to match (most of) the other built-ins. [1]: tc39/ecma402#487 * runtime/IntlObject.cpp: (JSC::IntlObject::finishCreation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consensus: tc39/ecma262#2057 (comment).
Tests: tc39/test262#2712.