Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Use consistent wording for List interactions #774

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 requested a review from ryzokuken April 12, 2023 16:20
@ryzokuken ryzokuken added the editorial Involves an editorial fix label Jun 29, 2023
@ben-allen
Copy link
Contributor

I've found a couple of other examples of the wording you're fixing:

negotiation.html:64: 1. If _canonicalizedTag_ is not an element of _seen_, append _canonicalizedTag_ as the last element of _seen_.

negotiation.html:270: 1. If _availableLocale_ is not *undefined*, append _locale_ to the end of _subset_.

@ben-allen
Copy link
Contributor

I'm wondering if by analogy to this change in 262:

<p>When an algorithm iterates over the elements of a List without specifying an order, the order used is the order of the elements in the List.</p>

we should add a sentence about how unless specified otherwise tables are iterated in table order, and then remove all the instances of , in table order, from loops

Copy link
Contributor

@ben-allen ben-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my eye it looks like there's a couple you've missed, but this is otherwise fantastic

@sffc
Copy link
Contributor

sffc commented Aug 23, 2023

@gibson042 Can you take a look at @ben-allen's feedback? This looks almost mergeable.

@gibson042 gibson042 force-pushed the 2023-04-list-interactions branch from c3def6b to 9514863 Compare November 14, 2023 01:08
@gibson042
Copy link
Contributor Author

@ben-allen please re-review!

I've found a couple of other examples of the wording you're fixing:

negotiation.html:64: 1. If _canonicalizedTag_ is not an element of _seen_, append _canonicalizedTag_ as the last element of _seen_.

negotiation.html:270: 1. If _availableLocale_ is not *undefined*, append _locale_ to the end of _subset_.

Thanks; fixed.

I'm wondering if by analogy to this change in 262:

<p>When an algorithm iterates over the elements of a List without specifying an order, the order used is the order of the elements in the List.</p>

we should add a sentence about how unless specified otherwise tables are iterated in table order, and then remove all the instances of , in table order, from loops

I've held off on doing this because I can't find a satisfactory way that is both in scope and discoverable—the latter characteristic being important, and handled in ECMA-262 by internal cross referencing (note how e.g. FindViaPredicate step 4 iterates over indices, which is defined in either step 2 or 3 to be a List with a link to the very section establishing the "When an algorithm iterates over the elements of a List without specifying an order, the order used is the order of the elements in the List" convention). We can pursue this in a followup.

@gibson042 gibson042 merged commit 578eaec into tc39:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Involves an editorial fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants