Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Throw a RangeError when mixing date-/timeStyle with other date/time options #43

Merged
merged 5 commits into from
Apr 23, 2020
Merged

Throw a RangeError when mixing date-/timeStyle with other date/time options #43

merged 5 commits into from
Apr 23, 2020

Conversation

anba
Copy link
Contributor

@anba anba commented Mar 31, 2020 •
edited
Loading

Fixes #40.
Supersedes #41.

anba added 5 commits March 31, 2020 05:07
@anba
Update dependencies
b0cd54b
@anba
Add missing biblio entry
0ebfa08
@anba
Handle timeStyle/dateStyle in ToDateTimeOptions
e311deb 
Don't add the date/time default values in ToDateTimeOptions when either
timeStyle or dateStyle is present.
@anba
Validate all date/time options, including "formatMatcher" even when u…
a7dbc7e 
…nused

This matches how other Intl service constructors work and to throw an error
when date-/timeStyle is used in conjunction with the other date/time options,
we need to retrieve the other options anyway.
@anba
Throw a RangeError when date/timeStyle is mixed with single date/time…
a4f6ccd 
… options

Drive-by change:
- Use standard EcmaSpeak when testing if both date- and timeStyle are undefined.

Fixes tc39#40.

Supersedes tc39#41.
@anba
Copy link
Contributor Author

anba commented Mar 31, 2020

There's still an open issue for how to handle things like date.toLocaleDateString("en", {timeStyle: "long"}). Also see #35, which is currently marked "editorial", but I don't think it's actually a purely editorial issue.

@anba anba mentioned this pull request Mar 31, 2020
Closed
@zbraniecki zbraniecki merged commit d725d38 into tc39:master Apr 23, 2020
@zbraniecki zbraniecki mentioned this pull request Apr 23, 2020
Closed
This was referenced Jun 4, 2020
Closed
Closed
@zbraniecki zbraniecki mentioned this pull request Jun 8, 2020
Closed
FrankYFTang added a commit to FrankYFTang/test262 that referenced this pull request Jun 12, 2020
@FrankYFTang
Sync the test w/ changes in intl-datetime-style 43
c9e2b95 
See
tc39/proposal-intl-datetime-style#43
@FrankYFTang FrankYFTang mentioned this pull request Jun 12, 2020
Merged
rwaldron pushed a commit to tc39/test262 that referenced this pull request Jun 17, 2020
@FrankYFTang @rwaldron
Sync the test w/ changes in intl-datetime-style 43
8d3dd2d 
See
tc39/proposal-intl-datetime-style#43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea about combining dateStyle/timeStyle with other options
2 participants
@anba @zbraniecki