Add back Record.isRecord #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was included before, and turns out to be needed in the context of #71
|
cc @ljharb |
|
Why not just typeof |
|
typeof will detect the primitive type (record, tuple) but not the primitive type boxed into their boxing objects (Record, Tuple). It is an edge case but it could be useful to detect it. |
|
More specifically, it’s an axiom for every object value (except Error, for legacy reasons), including boxed primitives, that there must be a cross-realm mechanism to distinguish it. |
ljharb
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was included before, and turns out to be needed in the context of #71