-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we have a Temporal [ @@toStringTag ] ?? #1539
Comments
Yes, we absolutely should - good catch! |
Would |
Good question! it’s not top-level, so maybe not - but it’s a namespace, so maybe yes? In general it can’t hurt to add it, and would potentially help debugging - I’d vote for adding it if nobody has objections. |
I agree. It seems like "namespace objects should generally have a @@toStringTag" should be added to the guidance discussed in https://github.com/tc39/notes/blob/master/meetings/2021-05/may-26.md#discussion-of-globals-and-guidance-for-future-proposals ? |
Guidance question → tc39/how-we-work#93 |
Fixes #1539. Co-authored-by: Jordan Harband <[email protected]>
Fixes #1539. Co-authored-by: Jordan Harband <[email protected]>
In "Stage 2 Draft / June 15, 2021" version of https://tc39.es/proposal-temporal/#sec-constructor-properties-of-the-temporal-object
I see no section for "Temporal [ @@toStringTag ]"
Should we have one like other 262/402 top level object?
Ref
https://tc39.es/ecma262/#sec-math-@@tostringtag
21.3.1.9 Math [ @@toStringTag ]
https://tc39.es/ecma262/#sec-atomics-@@tostringtag
25.4.15 Atomics [ @@toStringTag ]
https://tc39.es/ecma262/#sec-json-@@tostringtag
25.5.3 JSON [ @@toStringTag ]
https://tc39.es/ecma262/#sec-reflect-@@tostringtag
28.1.14 Reflect [ @@toStringTag ]
https://tc39.es/ecma402/#sec-Intl-toStringTag
8.1.1 Intl[ @@toStringTag ]
The text was updated successfully, but these errors were encountered: