Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have a Temporal [ @@toStringTag ] ?? #1539

Closed
FrankYFTang opened this issue Jun 17, 2021 · 5 comments · Fixed by #1541
Closed

Should we have a Temporal [ @@toStringTag ] ?? #1539

FrankYFTang opened this issue Jun 17, 2021 · 5 comments · Fixed by #1541
Assignees
Labels
needs plenary input Needs to be presented to the committee and feedback incorporated

Comments

@FrankYFTang
Copy link
Contributor

In "Stage 2 Draft / June 15, 2021" version of https://tc39.es/proposal-temporal/#sec-constructor-properties-of-the-temporal-object

I see no section for "Temporal [ @@toStringTag ]"

Should we have one like other 262/402 top level object?
Ref

https://tc39.es/ecma262/#sec-math-@@tostringtag
21.3.1.9 Math [ @@toStringTag ]

https://tc39.es/ecma262/#sec-atomics-@@tostringtag
25.4.15 Atomics [ @@toStringTag ]

https://tc39.es/ecma262/#sec-json-@@tostringtag
25.5.3 JSON [ @@toStringTag ]

https://tc39.es/ecma262/#sec-reflect-@@tostringtag
28.1.14 Reflect [ @@toStringTag ]

https://tc39.es/ecma402/#sec-Intl-toStringTag
8.1.1 Intl[ @@toStringTag ]

@ljharb
Copy link
Member

ljharb commented Jun 17, 2021

Yes, we absolutely should - good catch!

@Ms2ger Ms2ger self-assigned this Jun 17, 2021
Ms2ger added a commit that referenced this issue Jun 17, 2021
Ms2ger added a commit that referenced this issue Jun 17, 2021
@ptomato ptomato added the needs plenary input Needs to be presented to the committee and feedback incorporated label Jun 17, 2021
@ptomato
Copy link
Collaborator

ptomato commented Jun 17, 2021

Would Temporal.now need one as well?

@ljharb
Copy link
Member

ljharb commented Jun 18, 2021

Good question! it’s not top-level, so maybe not - but it’s a namespace, so maybe yes?

In general it can’t hurt to add it, and would potentially help debugging - I’d vote for adding it if nobody has objections.

@ptomato
Copy link
Collaborator

ptomato commented Jun 18, 2021

I agree. It seems like "namespace objects should generally have a @@toStringTag" should be added to the guidance discussed in https://github.com/tc39/notes/blob/master/meetings/2021-05/may-26.md#discussion-of-globals-and-guidance-for-future-proposals ?

@ptomato
Copy link
Collaborator

ptomato commented Jun 23, 2021

Guidance question → tc39/how-we-work#93

@ptomato ptomato self-assigned this Jul 2, 2021
ptomato pushed a commit that referenced this issue Jul 27, 2021
Ms2ger added a commit that referenced this issue Jul 27, 2021
Ms2ger added a commit that referenced this issue Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs plenary input Needs to be presented to the committee and feedback incorporated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants