toString() precision #1006
Merged
toString() precision #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested review from
Ms2ger,
justingrant,
pipobscure,
jasonwilliams,
sffc,
gibson042,
mattjohnsonpint and
ryzokuken
Codecov Report
@@ Coverage Diff @@
## main #1006 +/- ##
==========================================
+ Coverage 94.33% 94.38% +0.05%
==========================================
Files 18 18
Lines 6420 6556 +136
Branches 959 983 +24
==========================================
+ Hits 6056 6188 +132
- Misses 357 361 +4
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ms2ger
force-pushed
the
329-tostring-precision
branch
from
f3f9928 to
40a11a5
Compare
Ms2ger
requested changes
Oct 19, 2020
ptomato
force-pushed
the
329-tostring-precision
branch
from
dad50c0 to
256206b
Compare
Ms2ger
requested changes
Oct 20, 2020
ptomato
force-pushed
the
329-tostring-precision
branch
from
256206b to
afafce9
Compare
Ms2ger
approved these changes
Oct 21, 2020
In toString() we are going to have a different default rounding mode than in round() and difference(), so don't hardcode the default in the abstract operation. See: #329
This will be reused in Temporal.DateTime.prototype.toString when we add precision options. See: #329
This will be reused in Temporal.Instant.prototype.toString when we add precision options. See: #329
On DateTime.toString(), Time.toString(), and Instant.toString(), we add an options bag with the options `fractionalSecondDigits`, `smallestUnit`, and `roundingMode`. `smallestUnit` and `fractionalSecondDigits` control which units are output, and `roundingMode` is a rarely-needed option that allows other rounding behaviour than truncation. The default behaviour is changed as well. Previously seconds would not be output if the seconds and lower components would be 0, and the precision after the decimal point would be 0, 3, 6, or 9. After this change, seconds are always output, and all trailing zeroes after the decimal point are dropped. This change requires a lot of adjustments to expected test output. Closes: #329
ptomato
force-pushed
the
329-tostring-precision
branch
from
afafce9 to
33728dd
Compare
|
Addressed the review comments, so merging as per the approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this commit is adding
:00to expected test output; it's probably safe to ignore those parts when reviewing this.Closes: #329