-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding default calendar pros and cons #309
Conversation
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
- Coverage 78.26% 78.24% -0.03%
==========================================
Files 17 17
Lines 3410 3410
Branches 338 338
==========================================
- Hits 2669 2668 -1
Misses 725 725
- Partials 16 17 +1
Continue to review full report at Codecov.
|
This table looks generally good, with one exception: Based on my understanding from #268 (comment) , I'm not convinced that the language-region locale will give us the user's actual intended calendar preference. At the same time, the feedback I got about an API I proposed to expose more locale information (which could include the default calendar) was mostly negative and led me to stop pushing the proposal forward. So, I might say, more specifically, rather than " |
Any more feedback on this? Or shall I merge it? |
on - ☹️ Programmer needs to know to "opt in" to use the user's calendar preference
+ 🙂 Correct on backend end, but programmer needs to know to "opt in" on front end |
I added a new row about interoperability, which includes databases. The row you're pointing to is specifically about i18n correctness, which is not about databases. |
This has been open for 10 days. I'm going to merge this PR. Further changes can be in follow-up PRs. |
I started the table to compare the pros and cons of four default calendar options. I'm sure I'm missing something. @spectranaut, do you have the notes from the meeting on Thursday December 5?
@pipobscure @robpalme @apaprocki @caiolima @littledan