Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default calendar pros and cons #309

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Adding default calendar pros and cons #309

merged 2 commits into from
Jan 20, 2020

Conversation

sffc
Copy link
Collaborator

@sffc sffc commented Jan 10, 2020

I started the table to compare the pros and cons of four default calendar options. I'm sure I'm missing something. @spectranaut, do you have the notes from the meeting on Thursday December 5?

@pipobscure @robpalme @apaprocki @caiolima @littledan

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #309 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   78.26%   78.24%   -0.03%     
==========================================
  Files          17       17              
  Lines        3410     3410              
  Branches      338      338              
==========================================
- Hits         2669     2668       -1     
  Misses        725      725              
- Partials       16       17       +1
Impacted Files Coverage Δ
polyfill/lib/ecmascript.mjs 92.36% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94bf5cf...b190126. Read the comment docs.

@littledan
Copy link
Member

This table looks generally good, with one exception: Based on my understanding from #268 (comment) , I'm not convinced that the language-region locale will give us the user's actual intended calendar preference. At the same time, the feedback I got about an API I proposed to expose more locale information (which could include the default calendar) was mostly negative and led me to stop pushing the proposal forward.

So, I might say, more specifically, rather than "☹️ Programmer needs to know to "opt in" to use the user's calendar preference", using the text "Programmer needs to determine user's calendar preference without automatic region-based default". I'm not sure what emoji to assign it; I guess the emoji would depend on how strongly you believe the region represents the calendar preference.

@sffc
Copy link
Collaborator Author

sffc commented Jan 20, 2020

Any more feedback on this? Or shall I merge it?

@kaizhu256
Copy link
Contributor

on Impact on i18n correctness for Full ISO (option 1), how about changing it to opposite of User Preference (option 4), since most backend-operations use databases with full-iso:

- ☹️ Programmer needs to know to "opt in" to use the user's calendar preference
+ 🙂 Correct on backend end, but programmer needs to know to "opt in" on front end

@sffc
Copy link
Collaborator Author

sffc commented Jan 20, 2020

I added a new row about interoperability, which includes databases.

The row you're pointing to is specifically about i18n correctness, which is not about databases.

@sffc
Copy link
Collaborator Author

sffc commented Jan 20, 2020

This has been open for 10 days. I'm going to merge this PR. Further changes can be in follow-up PRs.

@sffc sffc merged commit 576dbb0 into main Jan 20, 2020
@sffc sffc deleted the calendar-table branch January 20, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants