Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Add WeakRef.prototype.constructor #131

Closed
leobalter opened this issue Jun 3, 2019 · 5 comments · Fixed by #133
Closed

Add WeakRef.prototype.constructor #131

leobalter opened this issue Jun 3, 2019 · 5 comments · Fixed by #133

Comments

@leobalter
Copy link
Member

the WeakRef.prototype.constructor is missing in the proposed specs, add it for consistency with other built-in constructors?

@leobalter
Copy link
Member Author

also, the text should be no more than:

The initial value of WeakRef.prototype.constructor is the intrinsic object %WeakRef%.

@mhofman
Copy link
Member

mhofman commented Jun 3, 2019

@erights mentions in #55 (comment) that the .constructor property can only appear in appendix B.

@leobalter
Copy link
Member Author

All right, so at least I hope this leads me to the right direction as I'll spend time authoring tests the way it's currently specified then.

@leobalter
Copy link
Member Author

Both WeakRef and FinalizationGroup must only appear on the System object

@erights please clarify if FinializationGroup.prototype.constructor should not exist as well?

The proposed specs currently have:

Is that correct?

@littledan
Copy link
Member

Following the conclusion of the "Annex B reform" topic, I think we should retain the FinalizationGroup.prototype.constructor property as is, and add an inline normative optional WeakRef.prototype.constructor property of %WeakRef%. I'll make a PR for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants