Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move named capture groups to finished proposals #102

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Move named capture groups to finished proposals #102

merged 1 commit into from
Jan 24, 2018

Conversation

adrianheine
Copy link
Contributor

No description provided.

@adrianheine adrianheine changed the title Move dotall to finished proposals Move dotall and named capture groups to finished proposals Dec 17, 2017
@littledan
Copy link
Member

I was imagining that proposals would move to finished once they were merged into the main spec. However, these don't seem to be merged yet.

@adrianheine
Copy link
Contributor Author

Sure, that makes sense. In that case this PR could just remain open until the others are merged, right?

@ljharb
Copy link
Member

ljharb commented Dec 17, 2017

Yes, that’s fine. Generally we prefer champions to make their own PRs for their proposals, though :-)

@adrianheine
Copy link
Contributor Author

Ok, sorry if I'm not actually helpful.

@ljharb
Copy link
Member

ljharb commented Dec 17, 2017

@adrianheine not at all, your PR is impeccable :-) just a bit premature, is all. We’ll leave it open until the timing is right.

@mathiasbynens
Copy link
Member

mathiasbynens commented Dec 19, 2017 •
edited by ljharb
Loading

dotAll is now merged

@adrianheine adrianheine changed the title Move dotall and named capture groups to finished proposals Move +named capture groups to finished proposals Dec 19, 2017
@adrianheine adrianheine changed the title Move +named capture groups to finished proposals Move named capture groups to finished proposals Dec 19, 2017
@adrianheine
Copy link
Contributor Author

adrianheine commented Dec 19, 2017 •
edited
Loading

I opened a new PR with just dotall.

@adrianheine
Copy link
Contributor Author

Squashed and rebased.

@ljharb
Copy link
Member

ljharb commented Dec 20, 2017

Linking to tc39/ecma262#1027

@chicoxyzzy
Copy link
Member

tc39/ecma262#1027 is merged

ljharb
ljharb approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased.

@ljharb ljharb merged commit c521bd5 into tc39:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adrianheine @littledan @ljharb @mathiasbynens @chicoxyzzy