Move the empty calendar option to the 'valid' test. #1552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I misread the ABNF syntax.
|
@littledan please confirm this is what you intended the spec to say; the inline ABNF is kinda hard to read. |
|
@littledan I've reviewed this and am ready to land, pending your response to @Ms2ger's question |
|
I think the brackets may have been unintentional; at least, I can't make sense of them. Let's resolve this discussion before landing the tests. |
|
Status? |
|
We need to make a call on the spec issue, and then probably close this PR as no-longer-needed. |
|
@Ms2ger thanks for the update! |
|
We made the call that this case actually should be invalid. See tc39/proposal-intl-locale#23 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misread the ABNF syntax.