Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for \8 in template/strict strings. #2654

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Add tests for \8 in template/strict strings. #2654

merged 1 commit into from
Jul 20, 2020

Conversation

rkirsling
Copy link
Member

Resolves #2653.

@rkirsling rkirsling mentioned this pull request Jun 9, 2020
Closed
rwaldron
rwaldron requested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you walk through how "\8" is covered in this syntax? I'm just not seeing it, but I'm feeling rusty, so appreciate your patience in advance:

EscapeSequence ::
    CharacterEscapeSequence
    LegacyOctalEscapeSequence

CharacterEscapeSequence ::
    SingleEscapeCharacter
    NonEscapeCharacter

SingleEscapeCharacter :: one of
    ' " \ b f n r t v

NonEscapeCharacter ::
    SourceCharacter but not one of EscapeCharacter or LineTerminator

not one of EscapeCharacter...

EscapeCharacter ::
    SingleEscapeCharacter
    DecimalDigit

The LegacyOctalEscapeSequence path is clear to me, and does not include 8.

test/language/expressions/template-literal/invalid-legacy-octal-escape-sequence-8.js

$DONOTEVALUATE();

`\8`;

This comment was marked as resolved.

Sign in to view

test/language/literals/string/legacy-non-octal-escape-sequence-8-strict.js

$DONOTEVALUATE();

'\8';

This comment was marked as resolved.

Sign in to view

@rwaldron
Copy link
Contributor

@leobalter can you check me on that ^^

@rkirsling
Copy link
Member Author

Sorry, this is indeed blocked by tc39/ecma262#2039 (as I'd initially misread B.1.2).
There's discussion on #2653 but I apologize for not indicating that here too.

@rwaldron
Copy link
Contributor

@rkirsling thanks for the clarification

@rkirsling rkirsling mentioned this pull request Jun 19, 2020
Merged
@leobalter leobalter changed the base branch from master to main July 15, 2020 17:41
@leobalter
Copy link
Member

FYI, I updated the base branch from master to main.

@leobalter
Copy link
Member

This achieved consensus today.

@leobalter leobalter merged commit fb05c9a into tc39:main Jul 20, 2020
@rkirsling rkirsling deleted the prohibit-escaped-8 branch July 27, 2020 21:56
@rkirsling rkirsling mentioned this pull request Aug 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaldron rwaldron rwaldron requested changes

@leobalter leobalter leobalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need tests for \8 in templates and strict strings
3 participants
@rkirsling @rwaldron @leobalter