Go back to a session per command #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The consensus seems to be that requests.Session is not thread safe; at least, not in all circumstances. Although no problems have been experienced with reusing sessions across threads, to be on the safe side, go back to creating a new session for each command. Rename _get_session method to get_session and leave in place in case someone wants to subclass AmcrestCamera and override it.
|
Thanks @pnbruckner |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consensus seems to be that requests.Session is not thread safe; at least, not in all circumstances. Although no problems have been experienced with reusing sessions across threads, to be on the safe side, go back to creating a new session for each command. Rename _get_session method to get_session and leave in place in case someone wants to subclass AmcrestCamera and override it.