Use unique amcrest exceptions #108
Conversation
Use amcrest specific exceptions where appropriate, such as for communication and login errors. Use retries and timeouts when generating authentation object. Check for invalid login when using Basic Authentication.
|
One change I'm not absolutely sure about. I noticed in Http._generate_token that the response from the camera was only checked for "invalid" and "error" if Digest Authentication was used. Specifically, it did not do this test if Basic Authentication was used. I suspected this was an oversight, so I changed it to do the test no matter which authentication type was used. Is that correct? Or did it only do that check if Digest Authentication was used on purpose? |
| @@ -10,8 +10,8 @@ | |||
| # GNU General Public License for more details. | |||
| # | |||
| # vim:sw=4:ts=4:et | |||
|
|
|||
| from amcrest.http import Http | |||
| from .exceptions import AmcrestError, CommError, LoginError | |||
There was a problem hiding this comment.
'.exceptions.AmcrestError' imported but unused
'.exceptions.CommError' imported but unused
'.exceptions.LoginError' imported but unused
|
Also, although these changes technically constitute an API change, it may not be worth going to version 2.0.0. 1.2.6 should be fine. Once these changes are released on pypi.org as a new version I'll update the HA amcrest components accordingly. |
Use amcrest specific exceptions where appropriate, such as for communication and login errors. Use retries and timeouts when generating authentation object. Check for invalid login when using Basic Authentication.