Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create httpx ssl context once #231

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Aug 31, 2023

fixes #230

It would be better to keep the httpx client around and reuse it but that would be a more invasive change.

src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Show resolved Hide resolved
src/amcrest/http.py Show resolved Hide resolved
src/amcrest/http.py Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
src/amcrest/http.py Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review September 4, 2023 14:52
@bdraco
Copy link
Contributor Author

bdraco commented Sep 4, 2023

Tested with a ip4m-1041w

Copy link
Collaborator

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@balloob balloob merged commit abde85c into tchellomello:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants