fix(ui): handle no acls for topic data (#510)

close #498
tchiotludo · Nov 15, 2020 · bceec35 · bceec35
1 parent 5f2728e
commit bceec35
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/client/src/containers/Topic/Topic/Topic.jsx b/client/src/containers/Topic/Topic/Topic.jsx
@@ -49,7 +49,7 @@ class Topic extends Root {
       {
         clusterId,
         topicId,
-        selectedTab: roles.topic && roles.topic['topic/data/read'] ? tabSelected : 'partitions',
+        selectedTab: roles.topic && roles.topic['topic/data/read'] ? tabSelected : 'configs',
         topicInternal: this.props.location.internal
       },
       () => {

diff --git a/client/src/containers/Topic/TopicList/TopicList.jsx b/client/src/containers/Topic/TopicList/TopicList.jsx
@@ -271,6 +271,16 @@ class TopicList extends Root {
       {colName: 'Replications', colSpan: 2},
       {colName: 'Consumer Groups', colSpan: 1}
     ];
+    let onDetailsFunction = undefined;
+
+    const actions = [constants.TABLE_CONFIG];
+    if(roles.topic && roles.topic['topic/data/read']) {
+      actions.push(constants.TABLE_DETAILS);
+      onDetailsFunction = (id) => `/ui/${selectedCluster}/topic/${id}/data`;
+    }
+    if(roles.topic && roles.topic['topic/delete']) {
+      actions.push(constants.TABLE_DELETE);
+    }
 
     return (
       <div>
@@ -406,13 +416,9 @@ class TopicList extends Root {
           onDelete={topic => {
             this.handleOnDelete(topic);
           }}
-          onDetails={(id) => `/ui/${selectedCluster}/topic/${id}/data`}
+          onDetails={onDetailsFunction}
           onConfig={(id) => `/ui/${selectedCluster}/topic/${id}/configs`}
-          actions={
-            roles.topic && roles.topic['topic/delete']
-              ? [constants.TABLE_DELETE, constants.TABLE_DETAILS, constants.TABLE_CONFIG]
-              : [constants.TABLE_DETAILS, constants.TABLE_CONFIG]
-          }
+          actions={actions}
         />
 
         {roles.topic['topic/insert'] && (