Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix produce multi / tombstone not working and forms layout issue #1396

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/components/Form/Input/Input.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PropTypes from 'prop-types';

const Input = props => {
const { name, label, placeholder, error, noStyle, wrapperClass, inputClass, ...rest } = props;
let wrapperClassRender = 'form-group';
let wrapperClassRender = 'form-group row';
let inputClassRender = 'col-sm-10';
if (noStyle) {
wrapperClassRender = '';
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/Form/Select/Select.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PropTypes from 'prop-types';

const Select = ({ name, label, items, error, wrapperClass, selectClass, blankItem, ...rest }) => {
return (
<div className={`${wrapperClass || 'form-group'}`}>
<div className={`${wrapperClass || 'form-group row'}`}>
{label !== '' ? (
<label htmlFor={name} className="col-sm-2 col-form-label">
{label}
Expand Down
13 changes: 4 additions & 9 deletions client/src/containers/Topic/TopicProduce/TopicProduce.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ class TopicProduce extends Form {
<div className="row khq-multiple col-sm-7">
{this.renderCheckbox(
'isMultiMessage',
'',
multiMessage,
() => {
this.setState({
Expand Down Expand Up @@ -247,7 +246,6 @@ class TopicProduce extends Form {
<div className="row khq-multiple col-sm-7">
{this.renderCheckbox(
'isTombstone',
'',
tombstone,
() => {
this.setState({ tombstone: !tombstone });
Expand Down Expand Up @@ -299,9 +297,9 @@ class TopicProduce extends Form {
'',
'Key',
'text',
undefined,
true,
'col-sm-6',
'col-sm-6 row',
'col-sm-12 p-0',
'input-class'
)}

Expand All @@ -310,9 +308,9 @@ class TopicProduce extends Form {
'',
'Value',
'text',
undefined,
true,
'col-sm-6',
'col-sm-6 row',
'col-sm-12 p-0',
'input-class'
)}
</div>
Expand Down Expand Up @@ -441,7 +439,6 @@ class TopicProduce extends Form {
<Header title={`Produce to ${topicId} `} />
{this.renderDropdown(
'Topic',
topics,
topicsSearchValue,
topicId,
value => {
Expand All @@ -462,7 +459,6 @@ class TopicProduce extends Form {
)}
{this.renderDropdown(
'Key schema',
keySchema.map(key => key.subject),
keySchemaSearchValue,
selectedKeySchema,
value => {
Expand Down Expand Up @@ -495,7 +491,6 @@ class TopicProduce extends Form {

{this.renderDropdown(
'Value schema',
valueSchema.map(value => value.subject),
valueSchemaSearchValue,
selectedValueSchema,
value => {
Expand Down