Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance search #1538

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

AlexisSouquiere
Copy link
Collaborator

@AlexisSouquiere AlexisSouquiere commented Jul 19, 2023

Fix #1532

This PR keeps the current behaviour that splits the search string by whitespace to build multiple search patterns. But the way it was supposed to works was confusing. For instance, by giving the following search string value to search with Contains option, the result could return records that contain only to whereas users were expecting records that contain value to search.

  • Allow giving a single pattern that contains whitespaces by enclosing it with double quotes (ex: "value to search")
  • Support complex patterns like searching for JSON key/value where we need to escape double quotes
  • Add details on the way the search works. Especially on the whitespace split + AND/OR operator in case of multiple patterns

On the following example, we are looking for records where the value contains P1 OR "field 1":"v1"

image

Add details in the search modal about white space and multiple patterns
@teimyBr
Copy link

teimyBr commented Jul 20, 2023

Seems like the filter now works a way better :D

@AlexisSouquiere AlexisSouquiere marked this pull request as ready for review July 26, 2023 13:44
@tchiotludo tchiotludo merged commit 96fd6af into tchiotludo:dev Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Topic Search Filter not work as expected
3 participants