Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve error management #1620

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

AlexisSouquiere
Copy link
Collaborator

@AlexisSouquiere AlexisSouquiere commented Nov 30, 2023

Fix #1617
Fix #1619

  • Removed validateStatus on axios request
  • Improved the AuthorizationException error management by splitting unauthenticated users and permission issues
  • Show a precise message on authorization errors
  • Remove unnecessary interceptor because it's already managed by the handleError function in api.js

Note: I had to use the localStorage to give the error message to the Login component because we are doing a redirection from outside a component. If you have a better idea, please suggest 😃

@AlexisSouquiere AlexisSouquiere marked this pull request as ready for review December 1, 2023 10:45
@tchiotludo tchiotludo merged commit 829f364 into tchiotludo:dev Dec 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants