Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connect update permissions #620

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

alozano3
Copy link
Contributor

@alozano3 alozano3 commented Mar 8, 2021

Hi, I want to allow a user to modify the state of a connector/task (resume, pause, restart) and not allow him to update the configs of the connector.

The first requirement is covered by the role connect/state/update and the second requirement by the role connect/update

The problem is that if I don't assign the role connect/update to the user, the search icon that redirects to the tasks tab where you can pause/resume is hidden.
connectList

Here is the tab that cannot be accessed without the connect/update role.
tasks

My suggestion is that the role connect/update only should apply when trying to update the configs (making the button disappear) and allow users with the role connect/state/update to change the state.
configs

@tchiotludo
Copy link
Owner

Hi @alozano3, it will fix this issue also I think : #614, no ?

@alozano3
Copy link
Contributor Author

alozano3 commented Mar 8, 2021

Yes! I didn't realize that there already was an opened issue. I read the #614 and the code of this PR doesn't disable the inputs of the config tabs, although the update button is hidden. Do you think it's worth to disable all the input fields?

@tchiotludo
Copy link
Owner

It can be more explicit to disabled input, people will understand clearly that no action is possible If you can

@alozano3
Copy link
Contributor Author

I disabled the inputs and the transforms textarea if the role connect/update is not granted.

@alozano3
Copy link
Contributor Author

@tchiotludo did you have time to review the last change?

@tchiotludo tchiotludo merged commit 7216a99 into tchiotludo:dev Mar 17, 2021
@tchiotludo
Copy link
Owner

Perfect thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants