Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display __consumer_offsets contents #856

Merged
merged 2 commits into from
Oct 16, 2021
Merged

Display __consumer_offsets contents #856

merged 2 commits into from
Oct 16, 2021

Conversation

timtebeek
Copy link
Contributor

Fixes #654

@timtebeek
Copy link
Contributor Author

There's still some awkward formatting of kafka-connect offset messages due to the metadata within there, but overal the messages are now readable and can be used for debugging, which was not possible before.

@tchiotludo tchiotludo merged commit ed4d391 into tchiotludo:dev Oct 16, 2021
@tchiotludo
Copy link
Owner

Seems to works well thanks 👍

@tchiotludo
Copy link
Owner

also added __transaction_state topic since we are loading the class needed :=)

@timtebeek timtebeek deleted the display_consumer_offsets_contents branch October 16, 2021 19:53
@timtebeek
Copy link
Contributor Author

Only realized later that it might be better to show a JSON serialized object for the group meta data value rather than the toString of the same object. Since the UI expects and does syntax highlighting for JSON. Would you agree and like to see that changed?

@tchiotludo
Copy link
Owner

Yes it will be better 😊

@timtebeek
Copy link
Contributor Author

Hmm; the returned OffsetAndMetadata class does not expose any getters for the JSON serializer to use, so you'd see an empty Object. We could:

  1. Leave it as is
  2. Map OffsetAndMetadata fields into a Map
  3. Map OffsetAndMetadata to a DTO with getters

I'd lean towards option 1 or 2, especially since this is all quite exceptional handling for special topics.

@tchiotludo
Copy link
Owner

For transactions topics, I've choose the Map options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle special topic like Schema Registry and __consumer_offsets and display data
2 participants