Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Take into account default topic configuration during topic creation #905

Merged
merged 1 commit into from
Dec 4, 2021
Merged

fix: Take into account default topic configuration during topic creation #905

merged 1 commit into from
Dec 4, 2021

Conversation

ThomasDangleterre
Copy link
Contributor

Fixes #821.

I created it as a draft because I wanna know if it's okay for you @tchiotludo before carrying on (adding tests...)

Regards

@tchiotludo
Copy link
Owner

Hi,
Seems to be ok for myself.
Please just add some unit test on the new endpoint and rename the route to ("api/topic/defaults-configs")
Thanks 👍

@ThomasDangleterre ThomasDangleterre marked this pull request as ready for review November 17, 2021 10:12
@ThomasDangleterre
Copy link
Contributor Author

Done :)

Thanks

@tchiotludo tchiotludo merged commit 6e9cc67 into tchiotludo:dev Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topics options are not taken into account
2 participants
@ThomasDangleterre @tchiotludo