merge :: 비밀번호 변경 UI 구현 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
baekteun
reviewed
Oct 27, 2022
...atures/RenewalPasswordFeature/Sources/AuthenticationEmail/AuthenticationEmailViewModel.swift
Show resolved
Hide resolved
Projects/Features/RenewalPasswordFeature/Sources/ChangePassword/ChangePasswordView.swift
Show resolved
Hide resolved
| VStack(spacing: 60) { | ||
| SecureDMSFloatingTextField("새 비밀번호 입력", text: $viewModel.password) { | ||
| } | ||
| .focused($focusField, equals: .beforePassword) |
There was a problem hiding this comment.
before..는 전 을 의미하는거라서 약간 안맞아 보여요
Projects/Features/RenewalPasswordFeature/Sources/EnterInformation/BlockEmailView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/RenewalPasswordFeature/Sources/EnterInformation/EnterInformationView.swift
Outdated
Show resolved
Hide resolved
…ion/EnterInformationView.swift Co-authored-by: baegteun <[email protected]>
…renewal-password-ui
baekteun
approved these changes
Oct 28, 2022
sian7563
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
죄송합니다. 제 무지함을 용서해 주십시오
분명 오류가 많으니 리뷰를 상세히 해 주세요
작업사항
AuthenticationEmailView, ViewModel, Component
ChangePasswordView, ViewModel, Component
EnterInformationView, ViewModel, Component