Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge :: 디자인 시스템 - 폰트 #12

Merged
merged 3 commits into from
Sep 21, 2022
Merged

merge :: 디자인 시스템 - 폰트 #12

merged 3 commits into from
Sep 21, 2022

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Sep 20, 2022 •
edited
Loading

개요

디자인 시스템 - 폰트 개발

작업사항

  • DMSTypoStyle
  • DMSTypo

사용방법

Text("ㄹㅇㅋㅋ")
  .dmsFont(.text(.extraLarge))

Text("Fdzz")
  .dmsFont(.title(.medium), color: .gray)

@baekteun baekteun added the ✨feat 새로운 기능을 추가 할 경우 label Sep 20, 2022
@baekteun baekteun self-assigned this Sep 20, 2022
@baekteun baekteun linked an issue Sep 20, 2022 that may be closed by this pull request
design system font #11
Closed
kimdaehee0824
kimdaehee0824 reviewed Sep 21, 2022
View reviewed changes
Projects/UsertInterfaces/DesignSystem/Sources/Typography/DMSTypoStyle.swift Outdated
var weight: Font.Weight { get }
}

public enum DMSTypoStyle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이포라는 이름 말고 폰트는 어떠신지요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은거같아여~ Typo부분 일괄적으로 Font로 바꿨습니다~~

kimdaehee0824
kimdaehee0824 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@kimdaehee0824 kimdaehee0824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조아따

@baekteun baekteun merged commit eb272c5 into develop Sep 21, 2022
@baekteun baekteun deleted the feat/11-design-system-font branch September 21, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sian7563 sian7563 sian7563 approved these changes

@kimdaehee0824 kimdaehee0824 kimdaehee0824 approved these changes

Assignees

@baekteun baekteun

Labels
✨feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

design system font
3 participants
@baekteun @kimdaehee0824 @sian7563