merge :: Points API #124
Merged
merge :: Points API #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
reviewed
Nov 12, 2022
| import Moya | ||
|
|
||
| public enum PointsAPI { | ||
| case fetchPointsList(String) |
baekteun
reviewed
Nov 14, 2022
Comment on lines
9
to
13
| public enum PointsType: String { | ||
| case all = "ALL" | ||
| case bonus = "BONUS" | ||
| case minus = "MINUS" | ||
| } |
| import Moya | ||
|
|
||
| public enum PointsAPI { | ||
| case fetchPointsList(String) |
baekteun
reviewed
Nov 15, 2022
Comment on lines
3
to
17
| public struct SinglePointResponseDTO: Decodable { | ||
| public init(id: String, date: Date, type: String, name: String, score: Int) { | ||
| self.id = id | ||
| self.date = date | ||
| self.type = type | ||
| self.name = name | ||
| self.score = score | ||
| } | ||
|
|
||
| public let id: String | ||
| public let date: Date | ||
| public let type: String | ||
| public let name: String | ||
| public let score: Int | ||
| } |
There was a problem hiding this comment.
id가 key 이름이랑 달라요 CodingKeys가 있는거도 아닌데
| } | ||
|
|
||
| public let id: String | ||
| public let date: Date |
There was a problem hiding this comment.
Date타입이 자동으로 Decode될지 모르겠는데 String으로 받고 Entity로 변환할때 String을 Date로 변환하는게 더 좋을거같아요
Comment on lines
12
to
19
| public init(schoolName: String, | ||
| name: String, | ||
| gcn: String, | ||
| profileImageURL: URL, | ||
| bonusPoint: Int, | ||
| minusPoint: Int, | ||
| phrase: String) { | ||
| self.schoolName = schoolName |
Comment on lines
3
to
20
| public struct PointEntity: Equatable, Hashable { | ||
| public init(id: String, | ||
| date: Date, | ||
| type: String, | ||
| name: String, | ||
| score: Int) { | ||
| self.id = id | ||
| self.date = date | ||
| self.type = type | ||
| self.name = name | ||
| self.score = score | ||
| } | ||
|
|
||
| public let id: String | ||
| public let date: Date | ||
| public let type: String | ||
| public let name: String | ||
| public let score: Int |
| import Foundation | ||
|
|
||
| public struct SinglePointResponseDTO: Decodable { | ||
| public init(id: String, date: Date, type: String, name: String, score: Int) { |
Comment on lines
4
to
8
| public init(id: String, | ||
| date: Date, | ||
| type: String, | ||
| name: String, | ||
| score: Int) { |
baekteun
reviewed
Nov 16, 2022
|
|
||
| public var task: Moya.Task { | ||
| switch self { | ||
| case .fetchPointsList(let type): |
| @@ -4,6 +4,7 @@ public struct FetchMyProfileResponseDTO: Decodable { | |||
| public let schoolName: String | |||
| public let name: String | |||
| public let gcn: String | |||
| public let profileImageURL: URL | |||
There was a problem hiding this comment.
url을 decode로 넣으려면 직접 decode를 구현해줘야하는거로 아는데, dto에서 String으로 받고 Entity에서 URL?로 받는방법 어떠신가요?
옵셔널인 이유는 사이드 이펙트를 ViewModel에서 처리하기 위함입니다 🤖
baekteun
approved these changes
Nov 17, 2022
kimdaehee0824
approved these changes
Nov 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
Points API
작업사항
Points API