Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge :: 자습실 목록 보기 기능 구현 #157

Merged
merged 17 commits into from
Dec 27, 2022

Conversation

sian7563
Copy link
Member

@sian7563 sian7563 commented Dec 27, 2022

개요

자습실 목록 보기 기능 구현

작업사항

자습실 목록 보기 기능 구현

UI

@sian7563 sian7563 added the ✨feat 새로운 기능을 추가 할 경우 label Dec 27, 2022
@sian7563 sian7563 self-assigned this Dec 27, 2022
@sian7563 sian7563 linked an issue Dec 27, 2022 that may be closed by this pull request
Comment on lines 41 to 43
}

.navigationTitle("자습실 신청")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의문의 공백이 있어요

Comment on lines 53 to 60
@ViewBuilder
func studyRoomListCellView(name: String,
floor: Int,
inUseHeadcount: Int,
totalAvailableSeat: Int,
availableGrade: Int,
availableSex: String) -> some View {
ZStack {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스타일 가이드랑 맞지 않아요

Comment on lines 61 to 63
Color.System.surface
.cornerRadius(6)
VStack(alignment: .leading, spacing: 18) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공백 넣어주세요

@@ -0,0 +1,57 @@
import BaseFeature
import Moya
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moya import 지워주세요

Comment on lines 4 to 6
case all = "남녀"
case male = "남자"
case female = "여자"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니.. api는 ALL MALE FEMALE로 오는데 rawValue값을 바꿔버리면..

Comment on lines 8 to 10
availableGrade: Int,
availableSex: AvailableSexType,
availableSex: String,
inUseHeadcount: Int,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니..

Comment on lines 26 to 29
public let name: String
public let availableGrade: Int
public let availableSex: AvailableSexType
public let availableSex: String
public let inUseHeadcount: Int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아아니...

@sian7563 sian7563 merged commit dd00a3e into develop Dec 27, 2022
@sian7563 sian7563 deleted the feat/147_Studyroom-Application-List-UI branch December 27, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨feat 새로운 기능을 추가 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

자습실 리스트 UI 퍼블리싱
3 participants