merge :: 잔류 신청 API 연동 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
baekteun
reviewed
Feb 19, 2023
There was a problem hiding this comment.
지금보니 스타일 가이드에 없이 알잘딱으로 스타일 맞춰진 내용이 좀 많네요. 이런것들 일관성있게 정하고 스타일 가이드에도 추가하는게 좋을거같아요
https://github.com/team-aliens/DMS-iOS/wiki/Team-Aliens---SwiftStyleGuide
...rvices/DataMappingModule/Sources/Remains/Response/FetchRemainsAvailableTimeResponseDTO.swift
Outdated
Show resolved
Hide resolved
.../Services/DomainModule/Sources/Remains/UseCases/FetchListRemainApplicationItemsUseCase.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 19, 2023
Projects/Services/DataModule/Sources/Remains/Repositories/lmpl/RemainsRepositoryImpl.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DomainModule/Sources/Entities/MyRemainApplicationItemsEntity.swift
Outdated
Show resolved
Hide resolved
.../Services/DomainModule/Sources/Remains/UseCases/FetchListRemainApplicationItemsUseCase.swift
Outdated
Show resolved
Hide resolved
kimdaehee0824
requested review from
sian7563,
kimdaehee0824 and
DSMInhyeKang
Projects/App/Sources/Application/DI/Remains/AppComponent+Remains.swift
Outdated
Show resolved
Hide resolved
.../DataMappingModule/Sources/Remains/Response/FetchListRemainApplicationItemsResponseDTO.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DataModule/Sources/Remains/Repositories/lmpl/RemainsRepositoryImpl.swift
Show resolved
Hide resolved
baekteun
reviewed
Feb 20, 2023
baekteun
reviewed
Feb 20, 2023
...s/Services/DomainModule/Sources/Remains/UseCases/FetchListRemainApplicationItemUseCase.swift
Outdated
Show resolved
Hide resolved
kimdaehee0824
approved these changes
Feb 21, 2023
baekteun
reviewed
Feb 21, 2023
...ervices/DataModule/Sources/Remains/UserCases/lmpl/FetchRemainsAvailableTimeUseCaselmpl.swift
Outdated
Show resolved
Hide resolved
Projects/Services/NetworkModule/Sources/Remains/Remote/Impl/RemoteRemainsDataSourceImpl.swift
Outdated
Show resolved
Hide resolved
Projects/Services/NetworkModule/Sources/Remains/Remote/Impl/RemoteRemainsDataSourceImpl.swift
Outdated
Show resolved
Hide resolved
Projects/Services/NetworkModule/Sources/Remains/Remote/RemoteRemainsDataSource.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 22, 2023
Projects/Services/DomainModule/Sources/Entities/RemainApplicationListEntity.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 22, 2023
Projects/Services/DataMappingModule/Sources/Enum/WeekType.swift
Outdated
Show resolved
Hide resolved
...rvices/DataMappingModule/Sources/Remains/Response/FetchRemainsAvailableTimeResponseDTO.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 22, 2023
Projects/Services/DomainModule/Sources/Entities/RemainsAvailableTimeEntity.swift
Outdated
Show resolved
Hide resolved
baekteun
approved these changes
Feb 22, 2023
DSMInhyeKang
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직
변경전
변경후
사용방법
기타