잔류 신청 페이지 UI 퍼블리싱 #167
Merged
잔류 신청 페이지 UI 퍼블리싱 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DSMInhyeKang
requested review from
baekteun,
HongSJae,
kimdaehee0824 and
sian7563
baekteun
reviewed
Feb 24, 2023
Projects/Features/ApplyFeature/Sources/ApplyPage/ApplyPageView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/ApplyFeature/Sources/ApplyPage/Component/ApplyListCellView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/ApplyFeature/Sources/ApplyPage/ApplyPageView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/ApplyFeature/Sources/ApplyPage/Component/ApplyListCellView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StayApplyFeature/Sources/Component/StayApplyListCellView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StayApplyFeature/Sources/Component/StayApplyListCellView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StayApplyFeature/Sources/Component/StayApplyNoticeView.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 24, 2023
Projects/Features/ApplyFeature/Sources/ApplyPage/Component/ApplyListCellView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/ApplyFeature/Sources/ApplyPage/Component/ApplyListCellView.swift
Outdated
Show resolved
Hide resolved
|
뭐지? 뭔가 미묘하게 weight들이 다르지 않아요? |
이거 제 시뮬에서만 얇게 뜨는건지 전에 여쭤봤는데 원래 좀 얇다고 하셔서,, 디자인 시스템에 있는 폰트는 제대로 적용되어 있어요😅 |
그러쿤요,, |
baekteun
reviewed
Feb 27, 2023
Projects/Features/ApplyFeature/Sources/ApplyPage/ApplyPageView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/ApplyFeature/Sources/ApplyPage/Component/ApplyListCellView.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 27, 2023
Projects/Features/RemainApplyFeature/Sources/Component/RemainApplyListCellView.swift
Outdated
Show resolved
Hide resolved
baekteun
approved these changes
Feb 27, 2023
HongSJae
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
잔류 신청 페이지의 UI 작업
작업사항
신청 메인페이지, 잔류 신청 페이지 UI 퍼블리싱
변경로직
Feature 구조 및 의존성 변경
변경전
ApplyFeature : 자습실 신청하기 기능
변경후
ApplyFeature :: 신청 메인 페이지
-> StudyRoomFeature : 자습실 신청 페이지
-> StayApplyFeature : 잔류 신청 페이지
UI