merge :: 잔류 신청 api 연동 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
baekteun
reviewed
Feb 28, 2023
Projects/Features/ApplyFeature/Sources/ApplyPage/Component/ApplyListCellView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/ApplyFeature/Sources/ApplyPage/ApplyPageViewModel.swift
Show resolved
Hide resolved
...s/Services/NetworkModule/Sources/StudyRooms/Remote/Impl/RemoteStudyRoomsDataSourceImpl.swift
Outdated
Show resolved
Hide resolved
...cts/Services/DomainModule/Sources/StudyRooms/UseCases/FetchMyStudyRoomAppItemsUserCase.swift
Outdated
Show resolved
Hide resolved
...ices/DataModule/Sources/StudyRooms/UseCases/Impl/FehtchMyStudyRoomAppItemsUserCaseImpl.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DataMappingModule/Sources/Enum/WeekType.swift
Outdated
Show resolved
Hide resolved
Projects/Features/RemainApplyFeature/Sources/RemainApplyViewModel.swift
Outdated
Show resolved
Hide resolved
Projects/Features/RemainApplyFeature/Sources/RemainApplyViewModel.swift
Outdated
Show resolved
Hide resolved
Projects/Features/RemainApplyFeature/Sources/Component/RemainApplyListCellView.swift
Show resolved
Hide resolved
baekteun
reviewed
Feb 28, 2023
Projects/Features/StudyRoomFeature/Sources/StudyRoomDetail/StudyRoomDetailViewModel.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DomainModule/Sources/Entities/MyStudyRoomAppItemsEntity.swift
Outdated
Show resolved
Hide resolved
Projects/Features/RemainApplyFeature/Sources/RemainApplyViewModel.swift
Outdated
Show resolved
Hide resolved
Comment on lines
78
to
81
| ) { [weak self] _ in | ||
| self?.fetchMyRemainApplicationItems() | ||
| self?.fetchRemainApplicationList() | ||
| } |
There was a problem hiding this comment.
이거
let remainOptions = self.remainApplicationList.remainOptions
.map {
if id == $0.id {
return RemainOptionsEntity(id: $0.id, title: $0.title, description: $0.description, isApplied: true)
} else {
return RemainOptionsEntity(id: $0.id, title: $0.title, description: $0.description, isApplied: false)
}
}
self.remainApplicationList = RemainApplicationList(remainOptions: remainOptions)로 하는거 어떄요?
There was a problem hiding this comment.
아 이거 if로 분기 안만들고 그냥 isApplied에 삼항 연산자 쓰는거도 괜찮겠네요
There was a problem hiding this comment.
commit 하긴 했는데 맞나 한 번 확인 부탁드려용
Projects/Features/RemainApplyFeature/Sources/RemainApplyViewModel.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 28, 2023
Projects/Features/RemainApplyFeature/Sources/RemainApplyViewModel.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 28, 2023
Projects/Features/RemainApplyFeature/Sources/Component/RemainApplyListView.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Feb 28, 2023
Projects/Features/RemainApplyFeature/Sources/RemainApplyView.swift
Outdated
Show resolved
Hide resolved
이렇게 하는게 맞나 잘 모르겠네요..?
baekteun
reviewed
Feb 28, 2023
Projects/Features/RemainApplyFeature/Sources/RemainApplyViewModel.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StudyRoomFeature/Sources/StudyRoomDetail/StudyRoomDetailViewModel.swift
Outdated
Show resolved
Hide resolved
baekteun
approved these changes
Feb 28, 2023
kimdaehee0824
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
잔류 신청 api 연동