Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat :: 회원가입 직후 탭바에서 신청 탭이 사라지는 오류 해결 #211

Merged
merged 18 commits into from
Mar 9, 2023

Conversation

DSMInhyeKang
Copy link
Member

개요

  • 회원가입 직후 features에 등록되지 않아서 탭바에 신청 탭이 표시되지 않는 문제를 해결합니다.

작업사항

  • 회원가입 직후 features에 등록 및 탭바에 신청 탭이 표시되도록 했습니다.

변경로직

SignUp -> DmsFeatures에 meal, notice, point, study_room, remain on/off 저장

@DSMInhyeKang DSMInhyeKang added ✨feat 새로운 기능을 추가 할 경우 ♻️refactor 코드 리팩토링 할 경우 labels Mar 7, 2023
@DSMInhyeKang DSMInhyeKang requested a review from a team as a code owner March 7, 2023 10:17
@DSMInhyeKang DSMInhyeKang self-assigned this Mar 7, 2023
@DSMInhyeKang DSMInhyeKang linked an issue Mar 7, 2023 that may be closed by this pull request
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 DmsFeature RootView쪽에 EnvironmentObject로 있어요

@DSMInhyeKang
Copy link
Member Author

이거 DmsFeature RootView쪽에 EnvironmentObject로 있어요

SigninView처럼 SignupView 쪽에서 appState 선언하고 처리할까요?

@baekteun
Copy link
Member

baekteun commented Mar 8, 2023

이거 DmsFeature RootView쪽에 EnvironmentObject로 있어요

SigninView처럼 SignupView 쪽에서 appState 선언하고 처리할까요?

네에

@DSMInhyeKang DSMInhyeKang reopened this Mar 9, 2023
@DSMInhyeKang DSMInhyeKang merged commit c7b89c3 into develop Mar 9, 2023
@DSMInhyeKang DSMInhyeKang deleted the 210-fix-apply-page-hiding-right-after-signup branch March 9, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨feat 새로운 기능을 추가 할 경우 ♻️refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

회원가입 직후 신청 페이지 사라지는 오류 해결
2 participants