Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

자습실 이용 시간 목록 API 연동 #227

Merged
merged 11 commits into from
Mar 19, 2023
Merged

자습실 이용 시간 목록 API 연동 #227

merged 11 commits into from
Mar 19, 2023

Conversation

DSMInhyeKang
Copy link
Member

개요

  • 자습실 이용 시간 API를 연동합니다.

작업사항

  • 자습실 이용 시간 Bottom Sheet의 API를 연동했습니다.

변경로직

  • StudyroomTimeListView <<< StudyroomTimeListCellView
  • StudyroomTimeListView - StudyRoomListViewModel : fetchStudyroomTimeList()

변경전

변경후

  • StudyroomTimeListView <<< StudyroomTimeListCellView
  • StudyroomTimeListView - StudyRoomListViewModel : fetchStudyroomTimeList()

@DSMInhyeKang DSMInhyeKang added the ✨feat 새로운 기능을 추가 할 경우 label Mar 18, 2023
@DSMInhyeKang DSMInhyeKang requested a review from a team as a code owner March 18, 2023 09:42
@DSMInhyeKang DSMInhyeKang self-assigned this Mar 18, 2023
@DSMInhyeKang DSMInhyeKang linked an issue Mar 18, 2023 that may be closed by this pull request
자습실 이용 시간 API 연동 #223
Closed
@baekteun
Copy link
Member

헉 $(BUNDLE_VERSION) 이거 CI 고치려고 1로 둔거에요

@baekteun
Copy link
Member

근데 CFBundleName이 1인건 실수가 맞아요 감삽니당

@DSMInhyeKang

This comment was marked as resolved.

Sign in to view
@baekteun

This comment was marked as resolved.

Sign in to view
@DSMInhyeKang

This comment was marked as resolved.

Sign in to view
@baekteun

This comment was marked as resolved.

Sign in to view
@DSMInhyeKang

This comment was marked as resolved.

Sign in to view
@DSMInhyeKang

This comment was marked as resolved.

Sign in to view
@baekteun
Copy link
Member

@baekteun 선배 타겟에 있는 info 안에 Bundle Version String(short) DMS-AliensTests 빼고 4개 다 $(BUNDLE_VERSION_STRING)으로 되어 있으세요??

아뇨 1이요

@DSMInhyeKang

This comment was marked as resolved.

Sign in to view
baekteun
baekteun reviewed Mar 18, 2023
View reviewed changes
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 자습실 가져오는 api는 정상인가요? api명세서보니 queryString추가되었는뎀

Projects/Features/StudyRoomFeature/Sources/StudyroomApplication/StudyRoomListViewModel.swift Outdated Show resolved Hide resolved
.../StudyRoomFeature/Sources/StudyroomApplication/StudyroomTimeList/StudyroomTimeListView.swift Show resolved Hide resolved
@DSMInhyeKang
Copy link
Member Author

DSMInhyeKang commented Mar 18, 2023 •
edited
Loading

이거 자습실 가져오는 api는 정상인가요? api명세서보니 queryString추가되었는뎀

요거 바꿔야 되는데 저번 notice time이랑 여기 부분 아직 서버 배포가 안 됐다고 해서 기다리고 있어요
주말 내로 해준다고 했는데 내일 다시 물어봐야 될 것 같아여

@DSMInhyeKang DSMInhyeKang merged commit c74086c into develop Mar 19, 2023
@DSMInhyeKang DSMInhyeKang deleted the 223-studyroom-time-list-API branch March 19, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HongSJae HongSJae HongSJae approved these changes

@baekteun baekteun baekteun approved these changes

Assignees

@DSMInhyeKang DSMInhyeKang

Labels
✨feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

자습실 이용 시간 API 연동
3 participants
@DSMInhyeKang @baekteun @HongSJae