날짜 포맷 변경으로 인한 DateFormatter 코드 리팩토링 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
reviewed
Mar 27, 2023
그나마 줄이면 이정도...?
baekteun
reviewed
Mar 28, 2023
Comment on lines
34
to
38
| let param = (iso8601Formatter.date(from: self) ?? .init()).toDMSNoticeTimeString() | ||
|
|
||
| let formatter = DateFormatter() | ||
| formatter.dateFormat = "yy/MM/dd HH:mm" | ||
| return formatter.date(from: param) ?? .init() |
There was a problem hiding this comment.
서버에서 데이터가 date 형식으로 오는데 date로 반환되어야 원래 사용하던 곳에서 사용 가능해서 string으로 바꾸고 한 번 더 포매팅을 해줬어요,,,,
There was a problem hiding this comment.
그걸 iso8601formatter가 하는거 아닌가요..?
There was a problem hiding this comment.
아 string으로 오는데 iso로 date로 바꾸고 string으로 변환한담에,,, 다시 포맷 맞춰서 date로 반환하게 짰어요... 그냥 저 dateFormat에 바로 넣으면 자꾸 현재 날짜/시간으로 초기화가 돼서,,,
이렇게 하면 시간 날짜 다 정상으로 나오긴 해요,,,, 좀 많이 하드코딩일 뿐,,,,,,,,
뻘짓을 신나게 하고 있었네요,,,
DSMInhyeKang
commented
Mar 30, 2023
There was a problem hiding this comment.
@baekteun 얘네도 뺄까요? 워치가 시뮬에선 작동 안 해서 확인을 못했어요
There was a problem hiding this comment.
똑같은 API라 iOS가 되면 둘 다 될거같은데,, 뭐 하늘에 빌어아죠
There was a problem hiding this comment.
음.,, 워치는 지금 날짜 사이에 -로 구분하는데 iOS 앱 처럼 /로 구분하게 맞출까요?
baekteun
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항