-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
자습실 신청 이름 오류 고치기 #245
Merged
DSMInhyeKang
merged 3 commits into
develop
from
244-studyroom-seat-applicant-name-does-not-appear
Apr 9, 2023
Merged
자습실 신청 이름 오류 고치기 #245
DSMInhyeKang
merged 3 commits into
develop
from
244-studyroom-seat-applicant-name-does-not-appear
Apr 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onAppear에 자습실 목록 가져오면 원래 400 => count 세서 맨 처음은 호출 X (== dropFirst()로 해야되는데 API request 부분에 넣었더니 작동 안 함)
SeatStatus 처리 변경
DSMInhyeKang
added
💬need discussion
논의가 필요한 경우
♻️refactor
코드 리팩토링 할 경우
👾bug
버그가 발생한 경우
labels
Apr 9, 2023
Closed
baekteun
reviewed
Apr 9, 2023
Projects/Features/StudyRoomFeature/Sources/StudyRoomDetail/StudyRoomDetailView.swift
Show resolved
Hide resolved
이거 근데 단일 버튼 형식으로 가는거 아니였어요? |
둘이 통합해서요 |
기억이 없어요,,,,, 제가 없는 회의가 있었나요 hoxy,,, |
예전에 막 준수님이 무지개 버튼 만들고 그런.. |
음.. 안드도 2버튼으로 처리하네요. 이건 없어졌던거로.. |
DSMInhyeKang
deleted the
244-studyroom-seat-applicant-name-does-not-appear
branch
April 9, 2023 23:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경로직
seat.status == .available ? num : name
--> seat.student == nil? num : name
변경전
seat.status == .available ? num : name
변경후
seat.student == nil? num : name
기타
Comment로 논의해야할 게 있습니다