Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: ๋””์ž์ธ ์‹œ์Šคํ…œ - TextField #30

Merged
merged 11 commits into from
Sep 28, 2022
Merged

๐Ÿ”€ :: ๋””์ž์ธ ์‹œ์Šคํ…œ - TextField #30

merged 11 commits into from
Sep 28, 2022

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Sep 27, 2022 •
edited
Loading

๊ฐœ์š”

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-09-27.at.22.54.21.mp4

์ž‘์—…์‚ฌํ•ญ

  • DMSFloatingTextField
  • SecureDMSFloatingTextField
  • DMSFormTextField
  • DMSFormTextEditor

์‚ฌ์šฉ๋ฐฉ๋ฒ•

DMSFloatingTextField("ใ„นใ…‡ใ…‹ใ…‹", text: $text)

SecureDMSFloatingTextField("fdzz", text: $text)

DMSFormTextField("ใ„นใ…‡zz", text: $text)

DMSFormTextEditor("fdใ…‹ใ…‹", text: $text)

@baekteun baekteun added the โœจfeat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ ํ•  ๊ฒฝ์šฐ label Sep 27, 2022
@baekteun baekteun self-assigned this Sep 27, 2022
@baekteun baekteun linked an issue Sep 27, 2022 that may be closed by this pull request
๋””์ž์ธ ์‹œ์Šคํ…œ - TextField #17
Closed
@baekteun baekteun requested a review from sian7563 as a code owner September 27, 2022 13:51
kimdaehee0824
kimdaehee0824 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@kimdaehee0824 kimdaehee0824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ œ๊ฐ€ ํ•˜๋ฃจ ์•ˆ์— Approve๋ฅผ ์•ˆํ•œ ๊ฑฐ๋Š” ํ•œ ์ค„ ์•Œ์•˜๋‹ค๋Š” ์ฐฉ๊ฐ์— ๋น ์ ธ ์žˆ๊ธฐ ๋•Œ๋ฌธ์ด๋ž๋‹ˆ๋‹ค
๋‹ค์Œ๋ถ€ํ„ฐ๋Š” ๋…์ด‰ ๋ฌธ์ž๋ฅผ ๋ณด๋‚ด์ฃผ์„ธ์š”

@baekteun baekteun merged commit 2e480e1 into develop Sep 28, 2022
@baekteun baekteun deleted the feat/17-design-system-textfield branch September 28, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sian7563 sian7563 sian7563 approved these changes

@kimdaehee0824 kimdaehee0824 kimdaehee0824 approved these changes

Assignees

@baekteun baekteun

Labels
โœจfeat ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ ํ•  ๊ฒฝ์šฐ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋””์ž์ธ ์‹œ์Šคํ…œ - TextField
3 participants
@baekteun @kimdaehee0824 @sian7563