-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge :: Base 세팅 #41
merge :: Base 세팅 #41
Conversation
|
||
public extension DmsAPI { | ||
var baseURL: URL { | ||
URL(string: "https://google.com")! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DMS 도메인이 없어 가상의 도메인을 넣어둔건가요?
BaseURL이 추후에 수정될 수 있게
TODO를 붙여주면 좋을 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 의견 감사합니다!
헉 실수로 reopen 했네요 죄송합니다 ㅜ.ㅜ |
히히 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 늦게 봤네요 죄송함다
개요
기본적인 Base 세팅 좀 했습니다.
작업사항
사용방법
isErrorOcuured, isLoading, errorMessage는 BaseViewModel을 상속받는 모든 ViewModel이 사용가능.
addCancellable은 Publisher가 sink이후 cancellable에 추가해야 동작할 수 있기 때문에 코드 중복이 일어날 가능성이 높아 추가한 method입니다.