merge :: 디자인 시스템 - Toast #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| Rectangle() | ||
| .fill(Color.GrayScale.gray1) | ||
| .cornerRadius(4) | ||
| .shadow(color: .GrayScale.gray9.opacity(0.08), radius: 16, x: 0, y: 1) |
There was a problem hiding this comment.
개인적으로 들여쓰기를 했스면 좋을 거 같아요
.shadow(color: .GrayScale.gray9.opacity(0.08),
radius: 16,
x: 0,
y: 1)There was a problem hiding this comment.
swiftLint상으로는 문제없어서 그냥 두긴했는데, 바꾸는게 좋을거같기도 하네용
There was a problem hiding this comment.
린트 반영 완료! 이외의 다른 기존 린트 방식도 변경
sian7563
approved these changes
Oct 16, 2022
kimdaehee0824
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
디자인 시스템의 Toast 작업
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-10-16.at.15.54.18.mp4
작업사항
사용방법