Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge :: Toast 자동 닫히기 로직 변경 #56

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

baekteun
Copy link
Member

개요

Toast 자동 닫히기 로직 변경

작업사항

  • 바인딩된 값이 바뀌는 시점을 기준으로 2초를 카운트 다운

변경로직

  • 2초 세는 시점 변경

변경전

  • onAppear를 기준으로 2초를 셈

변경후

  • isShowing의 onChange를 기준으로 2초를 셈

@baekteun baekteun added the ⚡️performance 성능을 개선 할 경우 label Oct 16, 2022
@baekteun baekteun self-assigned this Oct 16, 2022
@baekteun baekteun linked an issue Oct 16, 2022 that may be closed by this pull request
@baekteun baekteun merged commit ff5a9c1 into develop Oct 17, 2022
@baekteun baekteun deleted the 55-design-system-toast-logic-more-than branch October 17, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡️performance 성능을 개선 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

디자인 시스템 - 토스트 로직 변경
3 participants