Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge :: 로그인 Feature #70

Merged
merged 21 commits into from
Oct 21, 2022
Merged

merge :: 로그인 Feature #70

merged 21 commits into from
Oct 21, 2022

Conversation

baekteun
Copy link
Member

개요

로그인 Feature를 개발하였습니다.
하지만 사이드 이펙트가 크게 발생하여 사이드 이펙트를 픽스해버렸습니다

작업사항

  • 로그인 View
  • 로그인 ViewModel 대충인 로직
  • DMSFloatingTextField 키보드 레이아웃 문제 해결
  • GrayScale 색 다크모드 시 반전
  • Binding을 사용한 navigate 방식 간편화 함수

baekteun added 20 commits October 15, 2022 23:06
@baekteun
feat :: SigninFeature 모듈 추가
9fcca4c
@baekteun
fix :: Common -> Base로 디펜던시 변경
e52e32c
@baekteun
feat :: SigninComponent
18bc054
@baekteun
feat :: signinview, signinviewmodel
8dd7bd5
@baekteun
Merge branch 'develop' of https://github.com/DSM-FLOW/DMS-iOS into 42…
21e0d90 
…-signin-feature
@baekteun
Merge branch 'develop' of https://github.com/DSM-FLOW/DMS-iOS into 42…
2dc8946 
…-signin-feature
@baekteun
Merge branch 'develop' of https://github.com/DSM-FLOW/DMS-iOS into 42…
4d421e5 
…-signin-feature
@baekteun
Merge branch 'develop' of https://github.com/DSM-FLOW/DMS-iOS into 42…
f0e5135 
…-signin-feature
@baekteun
feat :: SigninView
c2014b5
@baekteun
Merge branch 'develop' of https://github.com/DSM-FLOW/DMS-iOS into 42…
178c185 
…-signin-feature
@baekteun
Merge branch 'develop' of https://github.com/DSM-FLOW/DMS-iOS into 42…
3431caa 
…-signin-feature
@baekteun
feat :: SigninView
2a69e5c
@baekteun
feat :: view + navigate
689346b
@baekteun
rename :: isNavigation -> isNavigate
07573a4
@baekteun
feat :: Signin Scene UI
4937375
@baekteun
Merge branch 'develop' of https://github.com/DSM-FLOW/DMS-iOS into 42…
870c3f4 
…-signin-feature
@baekteun
feat :: TextField에 textContetnType 지정
63eee5f
@baekteun
feat :: addCancellable 로그인 execute
638725b
@baekteun
feat :: navigateSignup
e619426
@baekteun
feat ::TextField 유효성 검사 조건 변경
7348c90
@baekteun baekteun added the ✨feat 새로운 기능을 추가 할 경우 label Oct 19, 2022
@baekteun baekteun self-assigned this Oct 19, 2022
@baekteun baekteun linked an issue Oct 19, 2022 that may be closed by this pull request
로그인 Feature 작업 #42
Closed
@baekteun baekteun merged commit 235dbb6 into develop Oct 21, 2022
@baekteun baekteun deleted the 42-signin-feature branch October 21, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sian7563 sian7563 sian7563 approved these changes

@kimdaehee0824 kimdaehee0824 kimdaehee0824 approved these changes

Assignees

@baekteun baekteun

Labels
✨feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

로그인 Feature 작업
3 participants
@baekteun @kimdaehee0824 @sian7563