merge :: School API #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
baekteun
reviewed
Oct 20, 2022
Projects/Services/DataMappingModule/Sources/School/Response/CheckSchoolCodeResponseDTO.swift
Outdated
Show resolved
Hide resolved
...ects/Services/DataMappingModule/Sources/School/Response/CheckSchoolQuestionResponseDTO.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DataMappingModule/Sources/School/Response/FetchSchoolListResponseDTO.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DataMappingModule/Sources/School/Response/SingleSchoolResponseDTO.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DataModule/Sources/School/Repositories/Stub/SchoolRepositoryStub.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DataModule/Sources/School/Repositories/Impl/SchoolRepositoryImpl.swift
Outdated
Show resolved
Hide resolved
Projects/Services/DomainModule/Sources/School/UseCases/GetSchoolListUseCase.swift
Outdated
Show resolved
Hide resolved
…eckSchoolQuestionResponseDTO.swift Co-authored-by: baegteun <[email protected]>
…eckSchoolCodeResponseDTO.swift Co-authored-by: baegteun <[email protected]>
…ngleSchoolResponseDTO.swift Co-authored-by: baegteun <[email protected]>
…tchSchoolListResponseDTO.swift Co-authored-by: baegteun <[email protected]>
baekteun
reviewed
Oct 20, 2022
Projects/Services/NetworkModule/Sources/School/Remote/RemoteSchoolDataSource.swift
Outdated
Show resolved
Hide resolved
Projects/Services/NetworkModule/Sources/School/Remote/Stub/RemoteSchoolDataSourceStub.swift
Outdated
Show resolved
Hide resolved
sian7563
approved these changes
Oct 20, 2022
baekteun
reviewed
Oct 20, 2022
...ervices/NetworkModule/Sources/School/Remote/Impl/DataTransfer/SingleSchoolListTransfer.swift
Outdated
Show resolved
Hide resolved
…aTransfer/SingleSchoolListTransfer.swift Co-authored-by: baegteun <[email protected]>
baekteun
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
School API 구현
작업사항
기타
너무 어려워서 태스트코드는 없습니다ㅜㅜ 형우님이 속성강의 한번 해주시는걸로
처음 만드는 API라 틀린 게 많으니 리뷰를 꼼꼼히 해주세요