merge :: (#44) Signup - AuthenticationCode UI #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/44_SignUp-UI
… feat/44_SignUp-UI
Closed
baekteun
reviewed
Oct 21, 2022
| VStack(alignment: .leading, spacing: 8) { | ||
| Text("DMS") | ||
| .dmsFont(.title(.extraLarge), color: .PrimaryVariant.primary) | ||
| .padding(.top, 28) |
There was a problem hiding this comment.
.top padding VStack에 주는게 더 좋을거같아요
Projects/Features/SignupFeature/Sources/AuthenticationCodeView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/SignupFeature/Sources/AuthenticationCodeView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/SignupFeature/Sources/AuthenticationCodeView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/SignupFeature/Sources/AuthenticationCodeView.swift
Outdated
Show resolved
Hide resolved
Comment on lines
13
to
15
| var isSigninButtonEnabled: Bool { | ||
| !schoolCode.isEmpty | ||
| } |
There was a problem hiding this comment.
code는 8자리 고정이니 8자리일때 활성화시키는거 어떤가요?
Comment on lines
5
to
14
| public protocol SignupDependency: Dependency { | ||
| var checkSchoolCodeUseCase: any CheckSchoolCodeUseCase { get } | ||
| } | ||
|
|
||
| public final class SignupComponent: Component<SignupDependency> { | ||
| public func makeView() -> some View { | ||
| AuthenticationCodeView( | ||
| viewModel: .init( | ||
| checkSchoolCodeUseCase: dependency.checkSchoolCodeUseCase | ||
| ) |
There was a problem hiding this comment.
AuthenticationCode에 대해 구현된것이니 Signup보다는 AuthenticationCode가 더 어울려보입니다!
Projects/Features/SignupFeature/Sources/AuthenticationCodeViewModel.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Oct 21, 2022
Comment on lines
3
to
5
|
|
||
| struct AuthenticationCodeView: View { | ||
|
|
There was a problem hiding this comment.
AuthenticationCode이라고 하였는데, 해당 페이지는 학교 인증코드 입력이니 SchoolCode로 하는게 어떤가요? 인증코드를 입력하는건 이메일 인증하는 것에도 있으니 혼동의 여지가 있어보여서요
Co-authored-by: baegteun <[email protected]>
Co-authored-by: baegteun <[email protected]>
Co-authored-by: baegteun <[email protected]>
Co-authored-by: baegteun <[email protected]>
Co-authored-by: baegteun <[email protected]>
Co-authored-by: baegteun <[email protected]>
baekteun
reviewed
Oct 25, 2022
Projects/Features/SignupFeature/Sources/AuthenticationCodeView.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Oct 25, 2022
Comment on lines
4
to
5
| struct SchoolCodeView: View { | ||
|
|
There was a problem hiding this comment.
Suggested change
| struct SchoolCodeView: View { | |
| struct SchoolCodeView: View { |
의미 불명 공백!
| } | ||
| @StateObject var viewModel: SchoolCodeViewModel | ||
| @FocusState private var focusField: FocusField? | ||
| @State var text: String = "" |
|
|
||
| @Published var isOnAutoSignup = true | ||
| @Published var isNavigateCheckSchool = false | ||
| @Published var isSuccessAuthenticationCode = false |
Comment on lines
5
to
6
| final class SchoolCodeViewModel: BaseViewModel { | ||
|
|
There was a problem hiding this comment.
Suggested change
| final class SchoolCodeViewModel: BaseViewModel { | |
| final class SchoolCodeViewModel: BaseViewModel { |
어.. 첫줄 공백 없이 가는거 어떠신가요
Co-authored-by: baegteun <[email protected]>
baekteun
approved these changes
Oct 25, 2022
kimdaehee0824
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
AuthenticationCode UI
작업사항
AuthenticationCode UI