Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): integer cast in version comparison #40

Merged
merged 1 commit into from
Jul 11, 2018
Merged

fix(charts): integer cast in version comparison #40

merged 1 commit into from
Jul 11, 2018

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented Jun 30, 2018 •
edited
Loading

This is the second of five PRs related to this issue

refs teamhephy/controller#72

@kingdonb
Copy link
Member Author

make that teamhephy/controller#72

@kingdonb kingdonb force-pushed the patch-integer-cast branch from ff62c0e to cc7f7f8 Compare July 11, 2018 18:28
@Cryptophobia Cryptophobia changed the title fix(builder): integer cast in version comparison fix(charts): integer cast in version comparison Jul 11, 2018
@Cryptophobia Cryptophobia self-requested a review July 11, 2018 18:52
Cryptophobia
Cryptophobia approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Cryptophobia Cryptophobia merged commit 81de9b7 into teamhephy:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryptophobia Cryptophobia Cryptophobia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingdonb @Cryptophobia