Skip to content

Commit

Permalink
lint: set golangci-lint.version to d278457390d8c314192c08a7024e4648c4…
Browse files Browse the repository at this point in the history
…0883af

Using d278457390d8c314192c08a7024e4648c40883af for now as
v1.15.0 does not compile with golang 1.12+ and HEAD cannot
pass test with golang 1.10.8.
Will be pegged to other version once there is a verion
can work OK with golang 1.12+ and golang 1.10.8.

Fixes: kata-containers#1345

Signed-off-by: Hui Zhu <[email protected]>
  • Loading branch information
teawater committed Mar 23, 2019
1 parent 18f3211 commit 787d658
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ externals:
golangci-lint:
description: "utility to run various golang linters"
url: "github.com/golangci/golangci-lint"
# Using HEAD for now as v1.15.0 does not compile with golang 1.12+. Will be
# pegged to the next release once it comes out.
# Using d278457390d8c314192c08a7024e4648c40883af for now as
# v1.15.0 does not compile with golang 1.12+ and HEAD cannot
# pass test with golang 1.10.8.
# Will be pegged to other version once there is a verion
# can work OK with golang 1.12+ and golang 1.10.8.
# https://github.com/kata-containers/tests/issues/1329
version: "HEAD"
# https://github.com/kata-containers/tests/issues/1345
version: "d278457390d8c314192c08a7024e4648c40883af"

0 comments on commit 787d658

Please sign in to comment.