Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for rust 1.80 by bumping time crates #1209

Closed
wants to merge 0 commits into from

Conversation

bryango
Copy link
Contributor

@bryango bryango commented Aug 8, 2024

Fixes #1207. The build fails with rust 1.80 due to an outdated time crate. This can be simply fixed by cargo update time.

This issue would soon affect all downstream (distro) packagers, and the fix is rather trivial and minimal, so I hope it can be fast-tracked into master (after CI of course). A bugfix release would be even better, but it's your decision! @CraftSpider @rm-dr

See:

@bryango bryango marked this pull request as ready for review August 8, 2024 02:54
@CraftSpider CraftSpider mentioned this pull request Aug 8, 2024
@CraftSpider
Copy link
Contributor

I just merged #1202, which should fix the unrelated build and clippy failures

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.92%. Comparing base (19654bf) to head (6ade679).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1209      +/-   ##
==========================================
- Coverage   46.99%   46.92%   -0.07%     
==========================================
  Files         176      177       +1     
  Lines       65196    65160      -36     
==========================================
- Hits        30639    30578      -61     
- Misses      34557    34582      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryango
Copy link
Contributor Author

bryango commented Aug 8, 2024

Ah thank you very much! This seems to have the working time crate now. Would you be interested in a minor bugfix release? Maybe we shall ping @pkgw?

@CraftSpider
Copy link
Contributor

pkgw would be the right person, I personally don't know the release process yet.

@bryango
Copy link
Contributor Author

bryango commented Aug 8, 2024

The relevant fix is now available in master at 6b49ca8. Before a proper release @pkgw , downstream may simply cherry-pick this commit. I have checked that it applies nicely on top of https://github.com/tectonic-typesetting/tectonic/tree/tectonic%400.15.0

@bryango bryango deleted the rust-1.80-fix branch August 8, 2024 05:01
@pkgw
Copy link
Collaborator

pkgw commented Aug 8, 2024

Sorry for being completely AWOL on all this ☹️

I'll make a release soon, and make a video explaining the process. With the release automation tools that we have, it can be quite straightforward, although there are a few concepts to learn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust 1.80.0 build issue
3 participants