This repository has been archived by the owner on Oct 16, 2022. It is now read-only.
Fix restores on UEFI Fedora and Red Hat systems #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing `else` meant that `grub2-mkconfig` was being invoked (correctly) but then `update-grub` was also being invoked. This is part 1 of the fix for teejee2008#423.
Fedora and Red Hat documentation directs users to directly update
the grub.cfg at /boot/efi/EFI/{redhat|fedora}/grub.cfg when they
manually update GRUB, and so that file no longer pulls in
/boot/grub2/grub.cfg. As a result, Timeshift restores were broken
for users who updated their GRUB config, since Timeshift only
updated the latter file prior to this patch. This patch makes
Timeshift directly update the appropriate EFI grub.cfg file.
This is part 2 of the fix for teejee2008#423
Conan-Kudo
suggested changes
Nov 13, 2021
Comment on lines
+2388
to
+2392
| if (target_distro.is_efi){ | ||
| sh += "%s grub2-mkconfig -o /boot/efi/EFI/%s/grub.cfg \n".printf(chroot, target_distro.dist_id); | ||
| else{ | ||
| sh += "%s grub2-mkconfig -o /boot/grub2/grub.cfg \n".printf(chroot); | ||
| } |
There was a problem hiding this comment.
/boot/grub2/grub.cfg is where it is for both EFI and non-EFI since Fedora 34 and RHEL/CentOS 9: https://fedoraproject.org/wiki/Changes/UnifyGrubConfig
There was a problem hiding this comment.
Nevertheless, RHEL8 and earlier are pretty long-lived. Preferably support those (understand if that has to be in my own fork though).
There was a problem hiding this comment.
Also dist_id won't work for Redhat as the path uses "redhat" but dist_id will be "rhel"
This was referenced Mar 1, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #423.